Ensure that new collection immutable_id is returned upon creation
#925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
||||||||||||||||||||||||
| Project |
datalab
|
| Run status |
|
| Run duration | 06m 29s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
ml-evs
commented
Oct 13, 2024
ml-evs
commented
Oct 13, 2024
BenjaminCharmes
pushed a commit
that referenced
this pull request
Oct 15, 2024
…925) * Add test that new collection ID is returned upon creation * Make sure that new collection immutable_id is returned upon creation * Fix typo * Remove unecessary test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when creating a collection the
immutable_idis returned asNone, as we do not set the database-assigned ID back to the creation model. As collection relationships work from this ID, it is very helpful to return it, so that another request toget_collectiondoes not need to be made to get the ID (see datalab-org/datalab-api#35) for the required Python API workaround for this).