Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin adding app tests for block rendering and file upload #938

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Oct 15, 2024

Long overdue, this will hopefully allow us to test file upload and block creation more easily.

@ml-evs ml-evs added the testing For issues/PRs that change how the package is tested label Oct 15, 2024
@ml-evs ml-evs changed the title Begin adding tests for edit page and file upload Begin adding app tests for block rendering and file upload Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.38%. Comparing base (21ed72d) to head (beeec1e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   68.38%   68.38%           
=======================================
  Files          62       62           
  Lines        3928     3928           
=======================================
  Hits         2686     2686           
  Misses       1242     1242           

Copy link

cypress bot commented Oct 15, 2024

datalab    Run #2590

Run Properties:  status check failed Failed #2590  •  git commit 39b2c45d47 ℹ️: Merge beeec1e6a796e833181be8251c2bb840da5ca1f6 into 21ed72d35f6b26d3670d1bfba22a...
Project datalab
Run status status check failed Failed #2590
Run duration 05m 05s
Commit git commit 39b2c45d47 ℹ️: Merge beeec1e6a796e833181be8251c2bb840da5ca1f6 into 21ed72d35f6b26d3670d1bfba22a...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 132

Tests for review

Failed  cypress/e2e/editPage.cy.js • 2 failed tests • End-to-end tests (firefox)

View Output

Test Artifacts
Edit Page > Clicks the upload buttons and checks that the modals are shown Screenshots
Edit Page > Uploads an XRD file, makes an XRD block and checks that the plot works Screenshots
Failed  cypress/e2e/editPage.cy.js • 2 failed tests • End-to-end tests (electron)

View Output

Test Artifacts
Edit Page > Clicks the upload buttons and checks that the modals are shown Test Replay Screenshots
Edit Page > Uploads an XRD file, makes an XRD block and checks that the plot works Test Replay Screenshots
Failed  cypress/e2e/editPage.cy.js • 2 failed tests • End-to-end tests (chrome)

View Output

Test Artifacts
Edit Page > Clicks the upload buttons and checks that the modals are shown Test Replay Screenshots
Edit Page > Uploads an XRD file, makes an XRD block and checks that the plot works Test Replay Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing For issues/PRs that change how the package is tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant