Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to work around lack of concurrency-safety in fsspec #82

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Try to work around lack of concurrency-safety in fsspec #82

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2423cc5
Try to work around lack of concurrency-safety in fsspec
jwodder Nov 14, 2022
da59235
Log a DEBUG message on KeyError
jwodder Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions datalad_fuse/fuse_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,10 @@ def getattr(self, path, fh=None):
fsspec_file, timestamp=self._adapter.get_commit_datetime(path)
)
if to_close:
fsspec_file.close()
try:
fsspec_file.close()
except KeyError:
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW if we are to proceed this way, would be worth adding at least DEBUG level log messages so we have some track of those

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: da59235

else:
# TODO: although seems to be logical -- seems to cause logging etc
# lgr.error("ENOENTing %s %s", path, fh)
Expand Down Expand Up @@ -259,7 +262,10 @@ def release(self, path, fh):
# files, so we need to provide some proper use of lru_cache
# to have not recently used closed
if f is not None and not f.closed:
f.close()
try:
f.close()
except KeyError:
pass
return 0

def readlink(self, path):
Expand Down