Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max listeners & 1.0.0 release #12

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Max listeners & 1.0.0 release #12

merged 2 commits into from
Dec 11, 2021

Conversation

liammclennan
Copy link
Contributor

Added a test for #8 and ES lint whitespace changes.

@liammclennan liammclennan changed the title Max listeners Max listeners & 1.0.0 release Dec 9, 2021
@nblumhardt
Copy link
Member

LGTM. May also be good to consider killing the off the redundant logged event anyway, in some future build? Seems wasteful to call setTimeout for every log event, if nothing actually relies on or expects that event 🤔

@liammclennan liammclennan merged commit 580ab1b into datalust:main Dec 11, 2021
@liammclennan liammclennan deleted the max-listeners-and-typings branch December 11, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nblumhardt nblumhardt nblumhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liammclennan @nblumhardt