Add Congresses to model admin and implement footnotes #184
Conversation
beamalsky
changed the title
There was a problem hiding this comment.
This seems fine, if a little unconventional! I don't love a non-standard way of show the asterisks, but I also understand each place you need to show it is slightly different. One thing that sticks out: Is there any need to show footnotes on the by-congress comparison view? Seems pretty important to note!
|
|
||
| class CongressAdmin(ModelAdmin): | ||
| model = Congress | ||
| menu_label = 'Edit Congresses' # ditch this to use verbose_name_plural from model |
committeeoversightapp/models.py
Outdated
|
|
||
| count = 1 | ||
| for rating in committeeratings: | ||
| if rating.congress.has_footnote: |
There was a problem hiding this comment.
Clever. This feels a bit unconventional, but I'm having trouble thinking of an alternative.
There was a problem hiding this comment.
Yep I also spent a while trying to think of something that's more built into Django, but this is where I landed. If you think of another way later I'd be curious to hear it! I think this is ok for one instance on the site, but if we had this same problem for other types of data it would be worth abstracting somehow.
committeeoversightapp/models.py
Outdated
| @@ -297,6 +321,13 @@ def percent_passed(self): | |||
|
|
|||
| return cap_100(percent_passed) | |||
|
|
|||
| @property | |||
There was a problem hiding this comment.
Does this offer any advantage over if congress.footnote?
|
Thanks @hancush! I added footnotes to the Congress comparison page like you suggested—though Jamie didn't specifically request it, I think you're right that consistency necessitates it. |
Overview
Closes #178. This PR adds the ability to create footnotes for each Congress on the site, and adds them to the templates following Jamie's request below. Also, while adding Congress to the ModelAdmin, I've added a more user-friendly way to adjust the
inactive_daysvalue for each Congress (as discussed in #176)From Jamie, here are the 3 places footnotes should show up:
Next to the congress on individual committee pages (footnote should be placed directly under chart)
Next to the “Projected Grade” on individual committee pages (footnote should be placed directly under chart)
Next to Current Congress (projected) on landing page (footnote should be at bottom of page)
Testing Instructions
hearings.dumpdocker-compose -f docker-compose.yml -f docker-compose.db-ops.yml run -e PGPASSWORD=postgres --rm dbload-dumpdocker-compose run --rm app python manage.py migratedocker-compose up