trying to get windows compile

graphium/graphium_cpp/features.h

@@ -195,8 +195,8 @@ template<> struct FeatureValues<double> {
         static_assert(std::is_floating_point_v<T>);
         return double(inputType);
     }
-
-    static constexpr bool is_finite(double v) {
+    
+    static bool is_finite(double v) {
         return std::isfinite(v);
     }
 

setup.py

@@ -22,31 +22,30 @@
 # Base variables required for compilation
 path_separator = "/"
 lib_folder_name = "lib"
-package_compile_args = [
-    "-O3",
-    "-Wall",
-]
+boost_include = "include/boost"
+package_compile_args = []
 
 # Updating variables used during compilation based on OS
 system = platform.system()
+if system == "Darwin" or system == "Linux":
+    package_compile_args += ["-O3", "-Wall", "-Wmaybe-uninitialized", "-Wuninitialized"]
+
 if system == "Darwin":
     package_compile_args += ["-mmacosx-version-min=10.15"]
 elif system == "Windows":
     path_separator = "\\"
     lib_folder_name = "Lib"
-
-if system == "Darwin" or system == "Linux":
-    package_compile_args += ["-Wmaybe-uninitialized", "-Wuninitialized"]
+    package_compile_args += ["/Wall"]
 
 # Extracting paths to torch and rdkit dependencies
 torch_dir = torch.__path__[0]
-print(rdkit.__path__[0].split(path_separator), '***')
 rdkit_lib_index = rdkit.__path__[0].split(path_separator).index(lib_folder_name)  # breaks on windows
 rdkit_prefix = "/".join(rdkit.__path__[0].split(path_separator)[:rdkit_lib_index])
 
 # Windows-specific changed to rdkit path
 if system == "Windows":
     rdkit_prefix += "/Library"
+    boost_include = "include"
 
 ext_modules = [
     Pybind11Extension(
@@ -69,7 +68,7 @@
             os.path.join(torch_dir, "include"),
             os.path.join(torch_dir, "include/torch/csrc/api/include"),
             os.path.join(rdkit_prefix, "include/rdkit"),
-            os.path.join(rdkit_prefix, "include/boost"),
+            os.path.join(rdkit_prefix, boost_include),
             numpy.get_include(),
         ],
         libraries=[