Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro updates #9

Merged
merged 12 commits into from
Jul 12, 2023
Merged

Micro updates #9

merged 12 commits into from
Jul 12, 2023

Conversation

maclandrol
Copy link
Member

Changelogs

  • Improve documentation and docstrings
  • Reviewed tutorial and correct typos
  • Fix some small bugs
  • Change doc color to have some distinct identity compared to graphium [to-be-discussed]

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

Did a global pass. Tutorial for the functional API are mostly the only thing missing.

@maclandrol maclandrol requested a review from hadim July 12, 2023 21:21
Copy link
Collaborator

@hadim hadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Manu. That looks great! (and will help even more an LLM to read the doc :-D)

I have logged an issue for the functional tuto/guide. I'll take care of it before the release.

@hadim hadim merged commit ce4bb53 into main Jul 12, 2023
@hadim hadim deleted the micro-updates branch July 12, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants