Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Use default InboxTaskStatus #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhancement: Use default InboxTaskStatus #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
171ba08
Enhancement: Use default InboxTaskStatus
igst Apr 24, 2024
4f1052e
Enhancement: Use default InboxTaskStatus
igst Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/InboxDocumentTaskApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,15 @@
$this->logger = $logger ?? new NullLogger();
}

public function createByDocumentId(DocumentId $documentId, ?\DateTimeInterface $arrivedAt = null, ?InboxDocumentTaskStatus $inboxDocumentTaskStatus = null): InboxDocumentTask
public function createByDocumentId(DocumentId $documentId, ?\DateTimeInterface $arrivedAt = null, ?InboxDocumentTaskStatus $inboxDocumentTaskStatus = InboxDocumentTaskStatus::Add): InboxDocumentTask
{
if (null === $inboxDocumentTaskStatus) {
$inboxDocumentTaskStatus = InboxDocumentTaskStatus::Add;
}

$payload = [];

if (null !== $arrivedAt) {
$payload['arrival'] = $this->dateTimeFormatter->format($arrivedAt);
}

$payload['status'] = $inboxDocumentTaskStatus->value;

Check failure on line 43 in src/InboxDocumentTaskApi.php

View workflow job for this annotation

GitHub Actions / Static Code Analysis (8.2) 

Cannot access property $value on Datana\Iusta\Api\Domain\Enum\InboxDocumentTaskStatus|null.

$this->logger->debug('Adding DocumentInboxTask with payload', ['payload' => $payload]);

Expand Down
2 changes: 1 addition & 1 deletion src/InboxDocumentTaskApiInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
*/
interface InboxDocumentTaskApiInterface
{
public function createByDocumentId(DocumentId $documentId, ?\DateTimeInterface $arrivedAt = null, ?InboxDocumentTaskStatus $inboxDocumentTaskStatus = null): InboxDocumentTask;
public function createByDocumentId(DocumentId $documentId, ?\DateTimeInterface $arrivedAt = null, ?InboxDocumentTaskStatus $inboxDocumentTaskStatus = InboxDocumentTaskStatus::Add): InboxDocumentTask;
}
Loading