Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineUp v4 compile errors in OverviewColumn #347

Closed
thinkh opened this issue Apr 1, 2020 · 1 comment
Closed

LineUp v4 compile errors in OverviewColumn #347

thinkh opened this issue Apr 1, 2020 · 1 comment
Assignees
Labels
priority: high type: bug Something isn't working

Comments

@thinkh
Copy link
Member

thinkh commented Apr 1, 2020

  • Release number or git hash:
  • Web browser version and OS:
  • Environment (local or deployed):

Steps to reproduce

  1. See lineupjs4 CircleCI build

Observed behavior

src/lineup/internal/OverviewColumn.ts:21:28 - error TS2339: Property 'setDefaultRenderer' does not exist on type 'OverviewColumn'.

21     (<OverviewColumn>this).setDefaultRenderer('boolean');
                              ~~~~~~~~~~~~~~~~~~

src/lineup/internal/OverviewColumn.ts:22:28 - error TS2339: Property 'setDefaultGroupRenderer' does not exist on type 'OverviewColumn'.

22     (<OverviewColumn>this).setDefaultGroupRenderer('boolean');
                              ~~~~~~~~~~~~~~~~~~~~~~~

src/lineup/internal/OverviewColumn.ts:23:28 - error TS2339: Property 'setDefaultSummaryRenderer' does not exist on type 'OverviewColumn'.

23     (<OverviewColumn>this).setDefaultSummaryRenderer('categorical');

Missing setDefaultRenderer, setSummaryRenderer, and setDefaultSummaryRenderer

Expected behavior

No build errors

@thinkh thinkh added type: bug Something isn't working priority: high labels Apr 1, 2020
@thinkh thinkh self-assigned this Apr 1, 2020
@thinkh
Copy link
Member Author

thinkh commented Apr 1, 2020

The listed functions were removed in the Column class with PR lineupjs/lineupjs#265:

https://github.com/lineupjs/lineupjs/pull/265/files#diff-65fc194206718f6b4835b47ed05ab0da

The renderers should be directly set to the column property instead. See the following DatesColumn example from the PR:

    super(id, integrateDefaults(desc, {
      renderer: 'datehistogram',
      groupRenderer: 'datehistogram',
      summaryRenderer: 'datehistogram'
    }));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant