Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set OverviewColumn renderer directly in column description #348

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Set OverviewColumn renderer directly in column description #348

merged 2 commits into from
Apr 2, 2020

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Apr 1, 2020 •
edited
Loading

Fixes #347

Summary

Set renderer properties directly in the column description instead of using dedicated methods.

@thinkh thinkh added the release: patch PR merge results in a new patch version label Apr 1, 2020
@thinkh thinkh force-pushed the thinkh/347_fix-overview-column branch from a75a7e1 to 3f1bd84 Compare April 1, 2020 14:44
@thinkh thinkh marked this pull request as ready for review April 1, 2020 14:52
oltionchampari
oltionchampari approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these fix the tests pass and the compiler doesn't complain.

@oltionchampari oltionchampari merged commit 58409cd into lineupjs4 Apr 2, 2020
@oltionchampari oltionchampari deleted the thinkh/347_fix-overview-column branch April 2, 2020 05:59
@thinkh thinkh mentioned this pull request Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oltionchampari oltionchampari oltionchampari approved these changes

@lehnerchristian lehnerchristian Awaiting requested review from lehnerchristian

Assignees

@oltionchampari oltionchampari

Labels
release: patch PR merge results in a new patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkh @oltionchampari