Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON'T merge [][m]: Render canvas files #618

Closed
wants to merge 1 commit into from
Closed

Conversation

mohamedsalem401
Copy link
Contributor

@mohamedsalem401 mohamedsalem401 commented Jan 16, 2024

For #578
This is the output so far
image

Issues:

  • Inline canvas files not working
  • Fix links

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
flowershow-ssr-r2 ❌ Failed (Inspect) Jan 16, 2024 3:23pm

@mohamedsalem401 mohamedsalem401 marked this pull request as draft January 16, 2024 15:23
@olayway
Copy link
Member

olayway commented Jan 17, 2024

@mohamedsalem401 I've commented on the problem in issue #578. Please take a look.

@olayway
Copy link
Member

olayway commented Jan 24, 2024

Closing this for now as not ready and we'll probably go with another approach. See my comment here: #578 (comment)

@olayway olayway closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants