Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make editable refer to root dir with setup.py #6

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

a-sumo
Copy link
Contributor

@a-sumo a-sumo commented Mar 25, 2023

I'm using an M1 chip and I encountered issue #5 . As suggested, I ran:

git clone https://github.com/dattalab/keypoint-moseq && cd keypoint-moseq
conda env create -f conda_envs/environment.linux_cpu.yml

And encountered the following error:

Pip subprocess error:                                                           
ERROR: file:///Users/armand/Documents/keypoint-moseq/conda_envs (from -r /Users/armand/Documents/keypoint-moseq/conda_envs/condaenv.m8fzb9y8.requirements.txt (line 2)) does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.                                                                  
                                                                                
failed                                                                          
                                                                                
CondaEnvException: Pip failed    

Which turned out to be caused by the line --editable in the environment.linux_cpu.yml not referring to the root directory containing the setup.py file. After making the changes in this commit, I successfully created the conda environment.
I assume this must be true for all 4 environments in conda_envs/ directory so I made the same change in all 4 environment files.

@calebweinreb
Copy link
Contributor

Thanks for the PR! Were you able to import keypoint_moseq and/or jax in the resulting environment? I want to confirm whether this is a good solution for M1 users.

@talmo
Copy link
Contributor

talmo commented Mar 25, 2023

FYI: Here's the related issue for Apple Silicon + Jax: jax-ml/jax#8074

(As of March 2023, it doesn't sound like it works natively yet with Metal.)

Can also confirm that this PR fixes the conda environment installations.

@talmo talmo mentioned this pull request Mar 25, 2023
@calebweinreb calebweinreb merged commit 368151a into dattalab:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants