Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user defined pull request number #369

Conversation

xli12
Copy link
Contributor

@xli12 xli12 commented May 29, 2024

As discussed in Issue #365 , here is the pull request for the feature of allowing a user-defined pull request number.

If there is a user-defined pull request number, and the pull request number cannot be found from the context, it will use the user-defined PR number.

By the way: thanks for creating this GitHub Action! It helps us a lot.

@christophwitzko
Copy link

It would be amazing to get this merged 🙏

Copy link
Owner

@davelosert davelosert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR. Overall, it looks great and I only left a few minor comments to address.

Big thank you for also fixing some of the formatting. I really should add some ESLint and Prettier 😅

src/writeSummaryToPR.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@xli12 xli12 requested a review from davelosert June 4, 2024 16:16
Copy link
Owner

@davelosert davelosert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you very much for this.
I'll merge and release this for now, as it has been sitting and waiting for long enough 🙂

@davelosert davelosert merged commit 9455b83 into davelosert:main Jun 11, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
# [2.4.0](v2.3.1...v2.4.0) (2024-06-11)

### Features

* allow user defined pull request number ([#369](#369)) ([9455b83](9455b83))
Copy link
Contributor

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants