-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Vitest workspace #377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xeho91: Thank you very much for this PR. I left one comment about the main bit, where I believe the wrong strings / paths are placed?
Also, could you update the options section of the readme.md
with these change?
And I would love to have another section in the Coverage-Thresholds Section of the Documentation with this warning:
Warning
Currently, this action does not import
the vite-configuration, but parses it as string to extract the coverage-thresholds by an regexp. In other words: All thresholds need to be directly defined in the config-file given to this action through the vite-config-path
input. E.g., when using workspace to extend a parent-configuration, the thresholds can not be defined in the parent-config.
I was lost for a moment, so I have to ask. Did I guess correctly - you meant the Default column?
No problem, I added at the top of aforementioned section. Is this where you wanted this warning to display? |
@xeho91 : Yep, perfect, thank you! As soon as the code-scan is succesfull, I will merge and release this. Thank you very much for this contribution! ❤️ |
Resolves #376