Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3 compatibility #85

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

python3 compatibility #85

wants to merge 7 commits into from

Conversation

mdshw5
Copy link

@mdshw5 mdshw5 commented Nov 16, 2018

This will give better python3 compatibility, and is consistent with other usage in the same script.

This will give better python3 compatibility, and is consistent with other usage in the same script.
@mdshw5 mdshw5 changed the title Use open constructor instead of file type python3 compatibility Nov 16, 2018
@mdshw5
Copy link
Author

mdshw5 commented Nov 16, 2018

I'm using leafcutter with snakemake, which supports only python3. In any case it looks like python3 support is an easy addition to leafcutter, and should help drive new user adoption.

@mdshw5
Copy link
Author

mdshw5 commented Nov 17, 2018

I jumped the gun on making this pull request. Will add more as I test against the python2.7 results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant