Moves nbformat and nbformat_minor to ymeta, changes the YNotebook eve… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt to support the new nbformat, and adds a local dirty property
davidbrochart
approved these changes
May 12, 2022
|
Yep, I can do it. |
|
I think the UI test failures are not related. |
|
Yep, me too. But I would like to wait for the results to be published to make sure are not related. |
|
The UI tests are not related. |
|
Thanks! |
fcollonval
added a commit
that referenced
this pull request
May 18, 2022
* Load document from the back-end using y-py * Load only documents metadata when collaborative * Delay closing the room in the backend * Update Yjs * Fix notebook ycell initialization * Watch file change in the back-end and overwrite Y document * Automatically save from the back-end * Small fixes * Use ypy-websocket's WebsocketServer * Poll for file changes for now, until watchfiles is fixed * Use ypy-websocket v0.1.2 * Remove watchfiles * Rename save_document to maybe_save_document, add collab_file_poll_interval config * Workaround ypy bug * Fix for new notebook * Use jupyter_ydoc * Rename yjs_echo_ws.py->ydoc_handler.py, YjsEchoWebSocket->YDocWebSocketHandler * Update ypy-websocket and jupyter_ydoc minimum versions * Use ypy-websocket>=0.1.6 * Update jupyter_ydoc>=0.1.4 * Move WEBSOCKET_SERVER global variable to YDocWebSocketHandler class attribute * Fix tests * Update jupyterlab/staging/package.json * Rename collab_file_poll_interval to collaborative_file_poll_interval, update extension migration documentation * Set room name as file_type:file_name * Don't save file if already on disk * Pin jupyter_ydoc>=0.1.5 * Set room name as format:type:path * Disable save button * Show caption only in collaborative mode * Sync file attributes with room name * Clear dirty flag when opening document * Pin jupyter_ydoc>=0.1.7 which observes the dirty flag * Don't save when dirty flag cleared * Moves nbformat and nbformat_minor to ymeta, changes the YNotebook eve… (#2) * Moves nbformat and nbformat_minor to ymeta, changes the YNotebook event to support the new nbformat, and adds a local dirty property * Pin jupyter_ydoc>=0.1.8 * Adds a local dirty property in the DocumentModel (#3) * Removes the initialization of the dirty property from the frontend (#4) * Removes the initialization of the dirty property from the frontend * Remove setting dirty in the SharedDocument Co-authored-by: hbcarlos <[email protected]> Co-authored-by: Frédéric Collonval <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves nbformat and nbformat_minor to ymeta.
Changes the YNotebook signal to support the new nbformat.
Adds a local dirty property to track changes in the frontend without modifying the shared dirty attribute.
References
Code changes
User-facing changes
Backwards-incompatible changes