Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app) RHIDP-2338 expose dynamic UI config #4

Conversation

gashcrumb
Copy link

Please explain the changes you made here.

This change exposes the dynamic UI configuration to dynamic plugins via
the scalprum API holder available with the scalprum React API. This
change also moves around some blocks for consistency and improves the
typing for the DynamicRootContext objects.

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

This change exposes the dynamic UI configuration to dynamic plugins via
the scalprum API holder available with the scalprum React API.  This
change also moves around some blocks for consistency and improves the
typing for the DynamicRootContext objects.

Signed-off-by: Stan Lewis <[email protected]>
@gashcrumb
Copy link
Author

Also here is a simple example that can render a custom mountpoint.

@gashcrumb
Copy link
Author

will rebase this against main...

@gashcrumb gashcrumb closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant