Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix help when in column zero #1923

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix help when in column zero #1923

merged 1 commit into from
Mar 13, 2023

Conversation

dimbleby
Copy link
Contributor

see davidhalter/parso#217, davidhalter/parso#218 for discussion - this is a much more limited and targeted fix

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b814ca2) 94.53% compared to head (f643523) 94.53%.

❗ Current head f643523 differs from pull request most recent head 0fbc2aa. Consider uploading reports for the commit 0fbc2aa to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1923   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files          80       80           
  Lines       11867    11871    +4     
=======================================
+ Hits        11218    11222    +4     
  Misses        649      649           
Impacted Files Coverage Δ
jedi/api/__init__.py 97.00% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidhalter
Copy link
Owner

@dimbleby Thanks a lot for the fix. This is exactly right.

If you're interested I'm happy to help you with other issues within Jedi as well. But thanks anyway!

@davidhalter davidhalter merged commit 6ee33bd into davidhalter:master Mar 13, 2023
@dimbleby
Copy link
Contributor Author

thanks - jedi (for me via the language server) mostly works great, I've little to complain about!

I did raise #1764 a while back and it still occasionally catches me out. If you're able to leave a hint there as to what would be needed to deal with it; and if that hint suggests that it's not too hard - then maybe one day I'd feel like taking a look at it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants