Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - txn.lease support #95

Closed
wants to merge 1 commit into from
Closed

WIP - txn.lease support #95

wants to merge 1 commit into from

Conversation

davissp14
Copy link
Owner

This feature doesn't seem to work as expected. Will be filing an issue to Etcd.

@codecov
Copy link

codecov bot commented Sep 3, 2017

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         386    407   +21     
=====================================
+ Hits          386    407   +21
Impacted Files Coverage Δ
spec/etcdv3_spec.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c4ba0...a9dcd5a. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 3, 2017

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         386    407   +21     
=====================================
+ Hits          386    407   +21
Impacted Files Coverage Δ
spec/etcdv3_spec.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c4ba0...a9dcd5a. Read the comment docs.

davissp14
davissp14 commented Sep 3, 2017
View reviewed changes
spec/etcdv3_spec.rb
end
it 'sets correct key' do
puts conn.get('txn').inspect
expect(conn.get('txn-test').kvs.first.value).to eq('failed')
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the txn.lease comparisons return successful no matter what the comparison is.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this hasn't been put into a release yet... Holding off on this..

@davissp14 davissp14 closed this Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davissp14