-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move weasyprint dependency pkg check to config validation #514
Comments
@srics should it not just be added to if not, is there a specific field in the config file where this can be checked if the user enabled it? |
@aramnhammer Yes, the following config field ( reports:
format: pdf
renderer: weasyprint Note, that we support the |
… to validators dict
… to validators dict
* #514: remove ImportError from generator_functions.py * #514: add ConfigValidator to config_validation.py module * #514: add dependency validator, add WeasyPrintDependency class to validators dict * #514: rm extra validator, move validation check to ReportsConfig * #514: use importlib to validate weasyprint install * #514: add a test (assumes weasyprint is not installed) * #514: clean up --------- Co-authored-by: aram yegiazaryan <[email protected]>
Currently the error message is shown only when the PDF report is about to be generated. Users will easily miss it.
Move this check to config validation stage and fail pebblo-server startup.
The text was updated successfully, but these errors were encountered: