-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xhtml2pdf report template #140
Merged
shreyas-damle
merged 27 commits into
daxa-ai:main
from
rutujaac:rutuja-xhtml2pdf-report-template
Feb 13, 2024
Merged
xhtml2pdf report template #140
shreyas-damle
merged 27 commits into
daxa-ai:main
from
rutujaac:rutuja-xhtml2pdf-report-template
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added length for snippetCount in report template
remove time conversion function
remove date util dependency
…uja-xhtml2pdf-report-template
…jaac/pebblo-private into rutuja-xhtml2pdf-report-template
…uja-xhtml2pdf-report-template
shreyas-damle
requested changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add output in the description of the PR with below
- Supported format and renderer
- Supported format and unsupported renderer
- Unsupported format and supported renderer
- I would suggest to add unit tests with this, so that we make sure that existing functionality is not breaking.
- Load history changes are included in this, please remove those.
shreyas-damle
previously approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Please consider taking unit tests in next PR.
…f-report-template
shreyas-damle
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non Pango Report PDF Template using xhtml2pdf:
Pass the value to renderer in Reports.generate_report function in reports.py
Default value for renderer is weasyprint
Scenarios tested:
weasyprint
renderer:Output:
xhtml2pdf
renderer:Output:
format
:Ouput:
Output: