Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature app history #151

Merged
merged 12 commits into from
Feb 16, 2024
Merged

Feature app history #151

merged 12 commits into from
Feb 16, 2024

Conversation

shreyas-damle
Copy link
Collaborator

rutujaac
rutujaac previously approved these changes Feb 14, 2024
Copy link
Collaborator

@rutujaac rutujaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pebblo/app/service/test.py Outdated Show resolved Hide resolved
pebblo/app/service/doc_helper.py Outdated Show resolved Hide resolved
pebblo/app/service/doc_helper.py Outdated Show resolved Hide resolved
pebblo/app/service/doc_helper.py Outdated Show resolved Hide resolved
rutujaac and others added 8 commits February 14, 2024 16:03
* added length for snippetCount in report template

* pyproject.toml update

* remove time conversion function

* remove date util dependency

* update template to add load history data

---------

Co-authored-by: rutujaCopods <[email protected]>
* App History code changes
* Code refactoring for loader doc to make code more modular
* Unit tests for loader doc
---------

Co-authored-by: Rajendra Kadam <[email protected]>
Co-authored-by: shreyas.cd <[email protected]>
* Pydentic DateTime Fix

* Key change in report data.

* Fixed file count with findings per label.

---------

Co-authored-by: shreyas.cd <[email protected]>
Log change.

Co-authored-by: shreyas.cd <[email protected]>
* added length for snippetCount in report template

* pyproject.toml update

* remove time conversion function

* remove date util dependency

* update template to add load history data

* update template data mapping

---------

Co-authored-by: rutujaCopods <[email protected]>
* MoreReportsPath Added

* Log messages updated.

---------

Co-authored-by: shreyas.cd <[email protected]>
* update template

* update load_history["moreReportsPath"]
* discovery load_ids fix

* logger mesasge change

---------

Co-authored-by: shreyas.cd <[email protected]>
shreyas-damle and others added 3 commits February 14, 2024 17:27
* Add load history json in report template (#106)

* added length for snippetCount in report template

* pyproject.toml update

* remove time conversion function

* remove date util dependency

* update template to add load history data

---------

Co-authored-by: rutujaCopods <[email protected]>

* App History (#109)

* App History code changes
* Code refactoring for loader doc to make code more modular
* Unit tests for loader doc
---------

Co-authored-by: Rajendra Kadam <[email protected]>
Co-authored-by: shreyas.cd <[email protected]>

* Shreyas pydentic datetime fix (#139)

* Pydentic DateTime Fix

* Key change in report data.

* Fixed file count with findings per label.

---------

Co-authored-by: shreyas.cd <[email protected]>

* LoadHistory Path Fix (#141)

Log change.

Co-authored-by: shreyas.cd <[email protected]>

* Load history json template data mapping updated (#143)

* added length for snippetCount in report template

* pyproject.toml update

* remove time conversion function

* remove date util dependency

* update template to add load history data

* update template data mapping

---------

Co-authored-by: rutujaCopods <[email protected]>

* MoreReportsPath Added in load history (#144)

* MoreReportsPath Added

* Log messages updated.

---------

Co-authored-by: shreyas.cd <[email protected]>

* fix word wrap and reports display length

* show more reports when values are more than 4

---------

Co-authored-by: rutujaCopods <[email protected]>
Co-authored-by: Shreyas Damle <[email protected]>
Co-authored-by: Rajendra Kadam <[email protected]>
Co-authored-by: shreyas.cd <[email protected]>
@shreyas-damle shreyas-damle marked this pull request as ready for review February 16, 2024 07:01
Copy link
Collaborator

@Raj725 Raj725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyas-damle shreyas-damle merged commit 6dbe137 into main Feb 16, 2024
7 of 11 checks passed
@srics srics deleted the feature_app_history branch July 24, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants