Add timezone to local UI dates #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raj725
reviewed
Mar 20, 2024
| dateOptions.minute = "numeric"; | ||
| } | ||
| if (showTimeZone) { | ||
| dateOptions.timeZoneName = "long"; |
There was a problem hiding this comment.
In the pdf report, we do not have long timezone format. Is it explicitly kept long on Local UI?
There was a problem hiding this comment.
We chose to use the long formats here because some of the short forms can be similar. I'll go ahead and update it for report pdfs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timezone to dates in Pebblo UI:
