Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding confidence score to entities and topic responses #460

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Adding confidence score to entities and topic responses #460

merged 6 commits into from
Aug 7, 2024

Conversation

dristysrivastava
Copy link
Collaborator

@dristysrivastava dristysrivastava commented Aug 5, 2024 •
edited
Loading

Changes:

  • Entity Classifier
    • Earlier it was sending entities, count, input_text
    • Now it will send entities, count, input_text, entity_details
    • e.g.,
      • input_text: Sachin's SSN is 222-85-4836.
      • entities: {'us-ssn': 1}
      • count: 1
      • entity_details: {'us-ssn': [{'location': '16_24', 'confidence_score': 'HIGH'}]}
  • Topic Classifier
    • Earlier it was only returning topic and its count
    • Now it will return with confidence score:
    • e.g.,
      • topics: {'financial-report': [{'confidence_score': 'HIGH'}]}
      • count: 1

@dristysrivastava dristysrivastava marked this pull request as ready for review August 6, 2024 09:19
@dristysrivastava dristysrivastava requested review from gr8nishan, shreyas-damle and srics and removed request for gr8nishan August 6, 2024 09:19
@dristysrivastava dristysrivastava self-assigned this Aug 6, 2024
@dristysrivastava dristysrivastava changed the base branch from main to pebblo-0.1.18 August 6, 2024 15:05
@gr8nishan gr8nishan merged commit 64956e3 into daxa-ai:pebblo-0.1.18 Aug 7, 2024
15 checks passed
dristysrivastava added a commit that referenced this pull request Aug 9, 2024
@dristysrivastava
Adding confidence score to entities and topic responses (#460)
e3ffe54 
* Adding confidence score to entities and topic responses

* Adding labels and fixing UTS

* Adding utils

* Fixing UT

* Remove unused imports

* Updating topic classifier

---------

Co-authored-by: dristy.cd <[email protected]>
gr8nishan added a commit that referenced this pull request Aug 13, 2024
@gr8nishan @dristysrivastava
Confidence score changes in Entity Classifier (#473)
e4418f8 
* Adding confidence score to entities and topic responses (#460)

* Adding confidence score to entities and topic responses

* Adding labels and fixing UTS

* Adding utils

* Fixing UT

* Remove unused imports

* Updating topic classifier

---------

Co-authored-by: dristy.cd <[email protected]>

* Added changes for prompt group

* resolved linting issue

* added changes for confidence score for entity classification

* added changes for confidence score

* review comment changes

* review comment changes

* review comment changes

---------

Co-authored-by: Dristy Srivastava <[email protected]>
Co-authored-by: dristy.cd <[email protected]>
gr8nishan added a commit that referenced this pull request Aug 14, 2024
@gr8nishan @dristysrivastava
Added changes for prompt group (#466)
06e8557 
* Adding confidence score to entities and topic responses (#460)

* Adding confidence score to entities and topic responses

* Adding labels and fixing UTS

* Adding utils

* Fixing UT

* Remove unused imports

* Updating topic classifier

---------

Co-authored-by: dristy.cd <[email protected]>

* Added changes for prompt group

* resolved linting issue

* conflic check fixes

* added changes for adding ip address in entity classifier

* added test case for ip address

---------

Co-authored-by: Dristy Srivastava <[email protected]>
Co-authored-by: dristy.cd <[email protected]>
gr8nishan added a commit that referenced this pull request Aug 20, 2024
@gr8nishan @dristysrivastava
added fix for entity classification happening in prompt api for prompt (
2506711 
#482)

* Adding confidence score to entities and topic responses (#460)

* Adding confidence score to entities and topic responses

* Adding labels and fixing UTS

* Adding utils

* Fixing UT

* Remove unused imports

* Updating topic classifier

---------

Co-authored-by: dristy.cd <[email protected]>

* Added changes for prompt group

* resolved linting issue

* conflic check fixes

* added changes for adding ip address in entity classifier

* added test case for ip address

* added fix for entity classification happening in prompt api for prompt

---------

Co-authored-by: Dristy Srivastava <[email protected]>
Co-authored-by: dristy.cd <[email protected]>
shreyas-damle pushed a commit that referenced this pull request Aug 21, 2024
@dristysrivastava @shreyas-damle
Adding confidence score to entities and topic responses (#460)
2465160 
* Adding confidence score to entities and topic responses

* Adding labels and fixing UTS

* Adding utils

* Fixing UT

* Remove unused imports

* Updating topic classifier

---------

Co-authored-by: dristy.cd <[email protected]>
shreyas-damle pushed a commit that referenced this pull request Aug 21, 2024
@gr8nishan @dristysrivastava @shreyas-damle
Confidence score changes in Entity Classifier (#473)
5db3801 
* Adding confidence score to entities and topic responses (#460)

* Adding confidence score to entities and topic responses

* Adding labels and fixing UTS

* Adding utils

* Fixing UT

* Remove unused imports

* Updating topic classifier

---------

Co-authored-by: dristy.cd <[email protected]>

* Added changes for prompt group

* resolved linting issue

* added changes for confidence score for entity classification

* added changes for confidence score

* review comment changes

* review comment changes

* review comment changes

---------

Co-authored-by: Dristy Srivastava <[email protected]>
Co-authored-by: dristy.cd <[email protected]>
shreyas-damle pushed a commit that referenced this pull request Aug 21, 2024
@gr8nishan @dristysrivastava @shreyas-damle
Added changes for prompt group (#466)
6bc04d3 
* Adding confidence score to entities and topic responses (#460)

* Adding confidence score to entities and topic responses

* Adding labels and fixing UTS

* Adding utils

* Fixing UT

* Remove unused imports

* Updating topic classifier

---------

Co-authored-by: dristy.cd <[email protected]>

* Added changes for prompt group

* resolved linting issue

* conflic check fixes

* added changes for adding ip address in entity classifier

* added test case for ip address

---------

Co-authored-by: Dristy Srivastava <[email protected]>
Co-authored-by: dristy.cd <[email protected]>
shreyas-damle pushed a commit that referenced this pull request Aug 21, 2024
@gr8nishan @dristysrivastava @shreyas-damle
added fix for entity classification happening in prompt api for prompt (
400f638 
#482)

* Adding confidence score to entities and topic responses (#460)

* Adding confidence score to entities and topic responses

* Adding labels and fixing UTS

* Adding utils

* Fixing UT

* Remove unused imports

* Updating topic classifier

---------

Co-authored-by: dristy.cd <[email protected]>

* Added changes for prompt group

* resolved linting issue

* conflic check fixes

* added changes for adding ip address in entity classifier

* added test case for ip address

* added fix for entity classification happening in prompt api for prompt

---------

Co-authored-by: Dristy Srivastava <[email protected]>
Co-authored-by: dristy.cd <[email protected]>
gr8nishan pushed a commit that referenced this pull request Aug 21, 2024
@shreyas-damle
Pebblo 0.1.18 to main (#486)
1094111 
* Adding confidence score to entities and topic responses (#460)
* Changes for confidence score in /loader/doc as well as UI API (#470)
* Confidence score changes in Entity Classifier (#473)
* Confidence score UI (#480)

* Added changes for entity groups (#466) 
* Adding IP address in entity classifier (#466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr8nishan gr8nishan gr8nishan approved these changes

@shreyas-damle shreyas-damle Awaiting requested review from shreyas-damle

@srics srics Awaiting requested review from srics

Assignees

@dristysrivastava dristysrivastava

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dristysrivastava @gr8nishan