Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#515 raise if --config is passed but file does not exist #516

Conversation

aramnhammer
Copy link
Contributor

Fix for #515.

Handles case when --config is unused -> where https://github.com/daxa-ai/pebblo/blob/f13be94416e60472d86e7fd24a628ec3b1be1d33/pebblo/app/config/config.py#L71C5-L71C16
will take None as its path argument, and the case where --config is passed but is not a valid path -> raises FileNotFoundError

@aramnhammer aramnhammer changed the title raise if --config is passed but file does not exist #515 raise if --config is passed but file does not exist Aug 29, 2024
Copy link
Collaborator

@Raj725 Raj725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the lint errors need to be fixed.

@Raj725 Raj725 requested a review from srics August 30, 2024 04:55
@srics srics merged commit 41ad455 into daxa-ai:main Aug 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants