Confidence score changes for DB #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dristysrivastava
requested review from
shreyas-damle,
srics,
gr8nishan and
Raj725
gr8nishan
reviewed
Aug 30, 2024
gr8nishan
reviewed
Sep 2, 2024
| self._get_snippet_details( | ||
| topic_data["snippetIds"], app_data["owner"] | ||
| ) | ||
| for entity, entity_data in app_data.get("docEntities").items(): |
There was a problem hiding this comment.
if app_data.get("docEntities") is None this line will throw an error
| if not findings_exists: | ||
| logger.debug("finding not exist") | ||
| findings = { | ||
| "appName": app_data["name"], |
There was a problem hiding this comment.
name , count , and snippetId, documents, owner will always have all these values present. any scenario when they will be missing
There was a problem hiding this comment.
These values will always be there
| total_snippet_count += findings["snippetCount"] | ||
| shallow_copy = findings.copy() | ||
| self.loader_findings_list.append(shallow_copy) | ||
| del findings["snippets"] |
There was a problem hiding this comment.
Will snippet be always there any scenario where it will not be present
There was a problem hiding this comment.
It will be always there, as we are creating findings in line no 103
gr8nishan
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added confidence score functionality for apps with storage as DB