Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB load history #529

Merged
merged 9 commits into from
Sep 4, 2024
Merged

DB load history #529

merged 9 commits into from
Sep 4, 2024

Conversation

shreyas-damle
Copy link
Collaborator

  • Implemented load history.
  • Handled "Findings" on "Documents With Findings" tab on application details page. For this, one change needed on the aidocument table about adding findings count per entity/topic.
  • Pydantic fixes needed due to upgrade to pydantic v2 => dict() to model_dump().
  • timeit() would run only when debug logs are enabled.
  • Delete pdf report when delete app is called from UI.

@shreyas-damle shreyas-damle changed the title DB loader history DB load history Sep 3, 2024
@shreyas-damle shreyas-damle marked this pull request as ready for review September 3, 2024 13:34
gr8nishan
gr8nishan reviewed Sep 3, 2024
View reviewed changes
pebblo/app/service/loader/document/document.py Outdated Show resolved Hide resolved
pebblo/app/service/loader/document/document.py Outdated Show resolved Hide resolved
pebblo/app/service/local_ui/loader_apps.py Outdated Show resolved Hide resolved
pebblo/app/service/local_ui/loader_apps.py Outdated Show resolved Hide resolved
pebblo/app/service/local_ui/loader_apps.py Outdated Show resolved Hide resolved
pebblo/app/service/local_ui/loader_apps.py Outdated Show resolved Hide resolved
@shreyas-damle
Pydantic fixes.
bf45172
@shreyas-damle
Changes after testing.
f17ba09
@shreyas-damle
Changes after testing.
17abe79
@shreyas-damle
- Replaced table names with enums.
b2e4f95 
- Handled findings on Documents With Findings tab on app details page.
- timeit would be called only when debug logs are enabled.
@shreyas-damle
Added comments.
bcf1b67
@shreyas-damle
- Add type hint for multiple functions.
aa42f28 
- Fixed mismatch in finding count.
gr8nishan
gr8nishan reviewed Sep 4, 2024
View reviewed changes
pebblo/app/service/local_ui/loader_apps.py Outdated Show resolved Hide resolved
pebblo/app/service/local_ui/loader_apps.py Outdated Show resolved Hide resolved
pebblo/app/service/local_ui/loader_apps.py Show resolved Hide resolved
gr8nishan
gr8nishan previously approved these changes Sep 4, 2024
View reviewed changes
@shreyas-damle shreyas-damle merged commit 7c9e51c into daxa-ai:main Sep 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr8nishan gr8nishan gr8nishan approved these changes

@dristysrivastava dristysrivastava Awaiting requested review from dristysrivastava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyas-damle @gr8nishan