Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mode knob in config under classifier #538

Merged
merged 7 commits into from
Sep 11, 2024
Merged

Adding mode knob in config under classifier #538

merged 7 commits into from
Sep 11, 2024

Conversation

dristysrivastava
Copy link
Collaborator

@dristysrivastava dristysrivastava commented Sep 10, 2024 •
edited
Loading

Changes:

  • Added mode in classifier section in config.
    • Possible options: all, entity, topic
  • Updated docs accordingly.
  • Updated /classify, /loader/doc API based on classifier -> mode value

@dristysrivastava dristysrivastava self-assigned this Sep 10, 2024
@dristysrivastava dristysrivastava marked this pull request as ready for review September 10, 2024 12:35
shreyas-damle
shreyas-damle reviewed Sep 10, 2024
View reviewed changes
pebblo/app/config/config_validation.py Outdated Show resolved Hide resolved
docs/gh_pages/docs/config.md Outdated Show resolved Hide resolved
pebblo/app/config/config.py Outdated Show resolved Hide resolved
@dristysrivastava dristysrivastava marked this pull request as draft September 10, 2024 16:15
srics
srics reviewed Sep 10, 2024
View reviewed changes
pebblo/app/service/classification.py Outdated Show resolved Hide resolved
pebblo/app/service/classification.py Outdated Show resolved Hide resolved
@dristysrivastava dristysrivastava marked this pull request as ready for review September 11, 2024 02:08
@srics srics merged commit 6ebdf6e into daxa-ai:main Sep 11, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srics srics srics approved these changes

@gr8nishan gr8nishan Awaiting requested review from gr8nishan

@Raj725 Raj725 Awaiting requested review from Raj725

@shreyas-damle shreyas-damle Awaiting requested review from shreyas-damle

Assignees

@dristysrivastava dristysrivastava

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dristysrivastava @srics @shreyas-damle