Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Security Issues #542

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

rutujaac
Copy link
Collaborator

@rutujaac rutujaac commented Sep 12, 2024

Addressed 3 issues of the following types:

  1. Make sure that this dynamic injection or execution of code is safe: Refactored the filtering function on Applications List table and Snippets listing to prevent use of eval() in JS.

  2. Make sure disabling auto-escaping feature is safe here: Added autoescape=jinja2.select_autoescape() to the Jinja2 Environment function to enable auto-escaping smartly for the given template file. All special characters would be rendered as strings.

Raj725
Raj725 previously approved these changes Sep 12, 2024
pebblo/app/pebblo-ui/src/components/snippetDetails.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Raj725 Raj725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyas-damle shreyas-damle merged commit 5bd5a84 into daxa-ai:main Sep 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants