Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing client_version error #547

Merged

Conversation

dristysrivastava
Copy link
Collaborator

@dristysrivastava dristysrivastava commented Sep 13, 2024

Issue:

send_discover[local]: 
request url http://localhost:8000/v1/app/discover, 
body b'{"name": "acme-sharepoint-ai-search-loader-app-5-0.1.19qa", "owner": "ACME Corp", "description": "Identity enabled SafeLoader app using Pebblo", "load_id": "911875e8-1251-477e-bf32-00b0b889a613", "runtime": {"type": "desktop", "host": "Sridhars-MacBook-Pro.local", "path": "/Users/sridhar/pebblo/demos/pebblo-identityrag-sharepoint-0.1.17-qa", "ip": "127.0.0.1", "platform": "macOS-14.6.1-arm64-arm-64bit", "os": "Darwin", "os_version": "Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000", "language": "python", "language_version": "3.11.9", "runtime": "Mac OSX"}, "framework": {"name": "langchain", "version": "0.2.32"}, "plugin_version": "0.1.1"}' 
len 701                        
response status 422 
response body {'detail': [{'type': 'missing', 'loc': ['body', 'client_version'], 'msg': 'Field required', 'input': {'name': 'acme-sharepoint-ai-search-loader-app-5-0.1.19qa', 'owner': 'ACME Corp', 'description': 'Identity enabled SafeLoader app using Pebblo', 'load_id': '911875e8-1251-477e-bf32-00b0b889a613', 'runtime': {'type': 'desktop', 'host': 'Sridhars-MacBook-Pro.local', 'path': '/Users/sridhar/pebblo/demos/pebblo-identityrag-sharepoint-0.1.17-qa', 'ip': '127.0.0.1', 'platform': 'macOS-14.6.1-arm64-arm-64bit', 'os': 'Darwin', 'os_version': 'Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6000', 'language': 'python', 'language_version': '3.11.9', 'runtime': 'Mac OSX'}, 'framework': {'name': 'langchain', 'version': '0.2.32'}, 'plugin_version': '0.1.1'}, 'url': '[https://errors.pydantic.dev/2.8/v/missing'}]}](https://errors.pydantic.dev/2.8/v/missing'%7D]%7D)
WARNING:langchain_community.document_loaders.pebblo:Received unexpected HTTP response code:                            422

Changes:

  • Updated client_version as Optional filed in discover API to support backward compatibility.
  • Also, client_version was not coming in /app/discovery Response for DB, added to AiBase Model

@srics srics merged commit 2b0d6d4 into daxa-ai:main Sep 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants