trigger deprecation if strftime format is used

dayspring-tech · May 21, 2024 · 292f314 · 292f314
1 parent cca86e5
commit 292f314
Show file tree

Hide file tree

Showing 21 changed files with 25 additions and 21 deletions.
diff --git a/.idea/php.xml b/.idea/php.xml
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/composer.json b/composer.json
@@ -16,7 +16,8 @@
   "require": {
     "php": "^8.0|^7.4",
     "phing/phing": "^2.17",
-    "ext-pdo": "*"
+    "ext-pdo": "*",
+    "symfony/deprecation-contracts": "^3.5"
   },
   "require-dev": {
     "phpunit/phpunit": "^9.0.0",

diff --git a/generator/default.properties b/generator/default.properties
@@ -104,8 +104,8 @@ propel.disableIdentifierQuoting = false
 # it is nice to change the defaults.
 
 propel.defaultTimeStampFormat = Y-m-d H:i:s
-propel.defaultTimeFormat = %X
-propel.defaultDateFormat = %x
+propel.defaultTimeFormat = H:i:s
+propel.defaultDateFormat = m/d/Y
 
 propel.defaultKeyType = phpName
 

diff --git a/generator/lib/builder/om/ExtensionQueryBuilder.php b/generator/lib/builder/om/ExtensionQueryBuilder.php
@@ -67,7 +67,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
             if ($this->getBuildProperty('addTimeStamp')) {
-                $now = strftime('%c');
+                $now = (new DateTime())->format(DateTimeInterface::ATOM);
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/ExtensionQueryInheritanceBuilder.php b/generator/lib/builder/om/ExtensionQueryInheritanceBuilder.php
@@ -109,7 +109,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5ExtensionNodeBuilder.php b/generator/lib/builder/om/PHP5ExtensionNodeBuilder.php
@@ -65,7 +65,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5ExtensionNodePeerBuilder.php b/generator/lib/builder/om/PHP5ExtensionNodePeerBuilder.php
@@ -65,7 +65,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5ExtensionObjectBuilder.php b/generator/lib/builder/om/PHP5ExtensionObjectBuilder.php
@@ -88,7 +88,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
             if ($this->getBuildProperty('addTimeStamp')) {
-                $now = strftime('%c');
+                $now = (new DateTime())->format(DateTimeInterface::ATOM);
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5ExtensionPeerBuilder.php b/generator/lib/builder/om/PHP5ExtensionPeerBuilder.php
@@ -88,7 +88,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
             if ($this->getBuildProperty('addTimeStamp')) {
-                $now = strftime('%c');
+                $now = (new DateTime())->format(DateTimeInterface::ATOM);
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5InterfaceBuilder.php b/generator/lib/builder/om/PHP5InterfaceBuilder.php
@@ -61,7 +61,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5MultiExtendObjectBuilder.php b/generator/lib/builder/om/PHP5MultiExtendObjectBuilder.php
@@ -145,7 +145,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5NestedSetBuilder.php b/generator/lib/builder/om/PHP5NestedSetBuilder.php
@@ -72,7 +72,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5NestedSetPeerBuilder.php b/generator/lib/builder/om/PHP5NestedSetPeerBuilder.php
@@ -72,7 +72,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5NodeBuilder.php b/generator/lib/builder/om/PHP5NodeBuilder.php
@@ -69,7 +69,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5NodePeerBuilder.php b/generator/lib/builder/om/PHP5NodePeerBuilder.php
@@ -69,7 +69,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5ObjectBuilder.php b/generator/lib/builder/om/PHP5ObjectBuilder.php
@@ -217,7 +217,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
             if ($this->getBuildProperty('addTimeStamp')) {
-                $now = strftime('%c');
+                $now = (new DateTime())->format(DateTimeInterface::ATOM);
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *
@@ -1017,7 +1017,8 @@ protected function addTemporalAccessorBody(&$script, Column $col)
         $script .= "
         }
 
-        if (strpos(\$format, '%') !== false) {
+        if (strpos(\$format, '%') !== false) {            
+            trigger_deprecation('dayspring-tech/propel1', '1.9', 'Using strftime style \"%\" formatting is deprecated. PHP 8.1 deprecated strftime().');
             return strftime(\$format, \$dt->format('U'));
         }
 

diff --git a/generator/lib/builder/om/PHP5PeerBuilder.php b/generator/lib/builder/om/PHP5PeerBuilder.php
@@ -109,7 +109,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
             if ($this->getBuildProperty('addTimeStamp')) {
-                $now = strftime('%c');
+                $now = (new DateTime())->format(DateTimeInterface::ATOM);
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/PHP5TableMapBuilder.php b/generator/lib/builder/om/PHP5TableMapBuilder.php
@@ -73,7 +73,7 @@ protected function addClassOpen(&$script)
  *
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/QueryBuilder.php b/generator/lib/builder/om/QueryBuilder.php
@@ -84,7 +84,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
             if ($this->getBuildProperty('addTimeStamp')) {
-                $now = strftime('%c');
+                $now = (new DateTime())->format(DateTimeInterface::ATOM);
                 $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *

diff --git a/generator/lib/builder/om/QueryInheritanceBuilder.php b/generator/lib/builder/om/QueryInheritanceBuilder.php
@@ -140,7 +140,7 @@ protected function addClassOpen(&$script)
  * $tableDesc
  *";
         if ($this->getBuildProperty('addTimeStamp')) {
-            $now = strftime('%c');
+            $now = (new DateTime())->format(DateTimeInterface::ATOM);
             $script .= "
  * This class was autogenerated by Propel " . $this->getBuildProperty('version') . " on:
  *