Bottled Memory Relic #328
Merged
Bottled Memory Relic #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wang429
commented
Jan 27, 2020
|
Filed daviscook477/BaseMod#243 for the tiny icon on the card |
dbjorge
reviewed
Feb 2, 2020
| } | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
This comment doesn't add any information that the method signature doesn't already cover
dbjorge
reviewed
Feb 2, 2020
| import javassist.expr.MethodCall; | ||
| import stsjorbsmod.relics.BottledMemoryRelic; | ||
|
|
||
| public class BottledMemoryPatch { |
There was a problem hiding this comment.
Based on searching for other base game references to inBottleFlame/etc, I think we're going to want a few more patches:
-
Duplicator,DollysMirror: Need to special case these to reset theinBottleMemoryfield back to false after they duplicate their target card -
FountainOfCurseRemoval: Need to special case to avoid picking bottle cards
There was a problem hiding this comment.
Sort of pretending that the FountainOfCurseRemoval actually did the right thing. ran through 250ish floors without seeing it, gave up.
dbjorge
requested changes
Feb 2, 2020
dbjorge
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight issue with using the CustomBottleRelic implementation; tiny bottle icon when rendering everywhere.
