Remove redundant async tests, do some cleanup #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove previous async tests and replace them with a single test that tests all four trait methods. The reasoning is that – given that the async trait impls always call the synchronous variant – the repeated async tests don't really bring much added value. A single test that ensures that async is working should be sufficient, and simplifies maintenance.
Remove previous async tests and replace them with a single test that tests all four trait methods. The reasoning is that – given that the async trait impls always call the synchronous variant – the repeated async tests don't really bring much added value. A single test that ensures that async is working should be sufficient, and simplifies maintenance.
dbrgn
changed the title
dbrgn
changed the title
asasine
approved these changes
May 26, 2024
There was a problem hiding this comment.
Looks good to me!
From the perspective of the test, there's no way to know that the impl is async-over-sync, so it would be great to come up with a way to actually run through the same test body for both, but I agree with your earlier point that of probably doesn't warrant the complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup commits. The async simplification was discussed here: #119 (review) @asasine do you want to take a look at this PR?
Note: The delay async tests were not removed, since in the delay module, the async impl doesn't just call through to the sync impl.