Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github/branch/edit action #195

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add github/branch/edit action #195

wants to merge 1 commit into from

Conversation

mikealfare
Copy link
Contributor

Description

Merge a source branch into a target branch on GitHub.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue

Comment on lines +35 to +41
- name: "Merge `${{ inputs.source-branch }}` into `${{ inputs.target-branch }}`"
uses: everlytic/[email protected]
with:
source_ref: ${{ inputs.source-branch }}
target_branch: ${{ inputs.target-branch }}
commit_message_template: "[automated] ${{ inputs.message }}"
github_token: ${{ secrets.FISHTOWN_BOT_PAT }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're checking everything out ourseleves anyways, why even use this action and not do it ourseleves? You're just extending this action with a little cleanup. Adding the merge part ourselves isn't hard and I can see value in this being centralized somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants