feat: allow aws session token in profiles file #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin-awd
requested review from
jessedobbelaere,
Jrmyy,
mattiamatrix,
nicor88 and
svdimchenko
as code owners
benjamin-awd
force-pushed
the
add-aws-session-token
branch
from
ca0c2ba
to
55a8a9b
Compare
|
See my comment in the github issue. I believe that we dont need session token explicitly pass as adapter param. Imho it's cumbersome, because you need to regenerate your profile yml really often, at the same time if your secret token is an env variable, boto3 will use it already without making it explicit as you proposed. |
Replied over at #458 (comment) |
2 tasks
tatiana
pushed a commit
to astronomer/astronomer-cosmos
that referenced
this pull request
Nov 10, 2023
Adds the `aws_session_token` argument to Athena, which was added to dbt-athena 1.6.4 in dbt-labs/dbt-athena#459 Closes: #609 Also addresses this comment: #578 (comment)
arojasb3
pushed a commit
to arojasb3/astronomer-cosmos
that referenced
this pull request
Jul 14, 2024
Adds the `aws_session_token` argument to Athena, which was added to dbt-athena 1.6.4 in dbt-labs/dbt-athena#459 Closes: astronomer#609 Also addresses this comment: astronomer#578 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #458
This PR adds support for passing in the AWS session token to a profiles.yml file, allowing for the use of short term credentials.
Models used to test - Optional
Checklist