Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation #1277

Closed
wants to merge 5 commits into from
Closed

[CT-2819] default__alter_relation_add_remove_columns macro does not use quoting with case sensitive Snowflake relation #1277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
92431f7
create bigquery version of test as it has different default behavior …
McKnight-42 Jul 16, 2024
6ef9eda
update dev-requirements
McKnight-42 Jul 17, 2024
435b2af
add changelog
McKnight-42 Jul 17, 2024
2ecd49e
typo
McKnight-42 Jul 17, 2024
99347fd
use universal version of test, remove bigquery version
McKnight-42 Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Under the Hood-20240717-101601.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Under the Hood
body: create test for checking case sensitivity on incrmeneal models that add new columns
time: 2024-07-17T10:16:01.119077-05:00
custom:
Author: McKnight-42
Issue: "1277"
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-common.git
git+https://github.com/dbt-labs/dbt-adapters.git
git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-adapters.git@mcknight/ct-2819
git+https://github.com/dbt-labs/dbt-adapters.git@mcknight/ct-2819#subdirectory=dbt-tests-adapter
# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
black>=24.3
Expand Down
6 changes: 5 additions & 1 deletion tests/functional/adapter/incremental/test_incremental_on_schema_change.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
from dbt.tests.adapter.incremental.test_incremental_on_schema_change import (
BaseIncrementalOnSchemaChangeSetup,
BaseIncrementalOnSchemaChange,
BaseIncrementalCaseSenstivityOnSchemaChange,
)

from dbt.tests.adapter.incremental.fixtures import (
_MODELS__A,
_MODELS__INCREMENTAL_SYNC_ALL_COLUMNS_TARGET,
Expand Down Expand Up @@ -251,3 +251,7 @@ def test_run_incremental_sync_all_columns_time_ingestion_partitioning(self, proj
compare_source = "incremental_sync_all_columns_time_ingestion_partitioning"
compare_target = "incremental_sync_all_columns_time_ingestion_partitioning_target"
self.run_twice_and_assert(select, compare_source, compare_target, project)


class TestIncrementalCaseSenstivityOnSchemaChange(BaseIncrementalCaseSenstivityOnSchemaChange):
pass
Loading