When parsing 'all_sources' should be a list of unique dirs (#5176)

* When parsing 'all_sources' should be a list of unique dirs * Changie * Fix some unit tests of all_source_paths * Convert 039_config_tests * Remove old 039_config_tests * Add test for duplicate directories in 'all_source_files'
dbt-labs · Apr 28, 2022 · f633e99 · f633e99
1 parent 4e57c51
commit f633e99
Show file tree

Hide file tree

Showing 31 changed files with 712 additions and 635 deletions.
diff --git a/.changes/unreleased/Fixes-20220427-102648.yaml b/.changes/unreleased/Fixes-20220427-102648.yaml
@@ -0,0 +1,7 @@
+kind: Fixes
+body: When parsing 'all_sources' should be a list of unique dirs
+time: 2022-04-27T10:26:48.648388-04:00
+custom:
+  Author: gshank
+  Issue: "5120"
+  PR: "5176"
diff --git a/core/dbt/config/project.py b/core/dbt/config/project.py
@@ -132,7 +132,11 @@ def _all_source_paths(
     analysis_paths: List[str],
     macro_paths: List[str],
 ) -> List[str]:
-    return list(chain(model_paths, seed_paths, snapshot_paths, analysis_paths, macro_paths))
+    # We need to turn a list of lists into just a list, then convert to a set to
+    # get only unique elements, then back to a list
+    return list(
+        set(list(chain(model_paths, seed_paths, snapshot_paths, analysis_paths, macro_paths)))
+    )
 
 
 T = TypeVar("T")

diff --git a/core/dbt/tests/fixtures/project.py b/core/dbt/tests/fixtures/project.py
@@ -187,6 +187,7 @@ def dbt_project_yml(project_root, project_config_update, logs_dir):
     if project_config_update:
         project_config.update(project_config_update)
     write_file(yaml.safe_dump(project_config), project_root, "dbt_project.yml")
+    return project_config
 
 
 # Fixture to provide packages as either yaml or dictionary

diff --git a/test/integration/039_config_tests/extra-alt/untagged.yml b/test/integration/039_config_tests/extra-alt/untagged.yml
diff --git a/test/integration/039_config_tests/extra-alt/untagged2.yml b/test/integration/039_config_tests/extra-alt/untagged2.yml
diff --git a/test/integration/039_config_tests/models-alt/schema.yml b/test/integration/039_config_tests/models-alt/schema.yml
diff --git a/test/integration/039_config_tests/models-alt/tagged/model.sql b/test/integration/039_config_tests/models-alt/tagged/model.sql
diff --git a/test/integration/039_config_tests/models-alt/untagged.sql b/test/integration/039_config_tests/models-alt/untagged.sql
diff --git a/test/integration/039_config_tests/models-get/any_model.sql b/test/integration/039_config_tests/models-get/any_model.sql
diff --git a/test/integration/039_config_tests/models-ok/ok.sql b/test/integration/039_config_tests/models-ok/ok.sql
diff --git a/test/integration/039_config_tests/models/schema.yml b/test/integration/039_config_tests/models/schema.yml
diff --git a/test/integration/039_config_tests/models/tagged/model.sql b/test/integration/039_config_tests/models/tagged/model.sql
diff --git a/test/integration/039_config_tests/models/untagged.sql b/test/integration/039_config_tests/models/untagged.sql
diff --git a/test/integration/039_config_tests/project/dbt_project.yml b/test/integration/039_config_tests/project/dbt_project.yml
diff --git a/test/integration/039_config_tests/project/profiles.yml b/test/integration/039_config_tests/project/profiles.yml
diff --git a/test/integration/039_config_tests/seeds-alt/some_seed.csv b/test/integration/039_config_tests/seeds-alt/some_seed.csv
diff --git a/test/integration/039_config_tests/seeds/seed.csv b/test/integration/039_config_tests/seeds/seed.csv