Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove operations #1117

Closed
beckjake opened this issue Nov 12, 2018 · 0 comments
Closed

Remove operations #1117

beckjake opened this issue Nov 12, 2018 · 0 comments
Assignees

Comments

@beckjake
Copy link
Contributor

Feature

We should remove the concept of operations on the jinja level and replace them + adapter.run_operation() with adapter.execute_macro(). The node type Operation should remain.

Feature description

This should be totally safe to remove: dbt currently defines two operations and does not make operations available to users in any way. Both just execute the contents of existing macros, get_catalog and get_relations, which do all the hard work.

There's a bunch of supporting machinery in the parser/loader that can get ripped out as well. Operations will still exist in the graph, as hooks have been operations before this jinja construct existed, and that's fine.

Other issues to keep in mind with respect to this:

Who will this benefit?

This will make dbt a bit more internally consistent and reduce the amount of things users need to understand if they want to implement adapters.

@drewbanin drewbanin added this to the Stephen Girard milestone Nov 13, 2018
@beckjake beckjake self-assigned this Dec 5, 2018
beckjake added a commit that referenced this issue Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants