Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental parser correctness checks to tracking #3503

Closed
nathaniel-may opened this issue Jun 28, 2021 · 2 comments · Fixed by #3553
Closed

Add experimental parser correctness checks to tracking #3503

nathaniel-may opened this issue Jun 28, 2021 · 2 comments · Fixed by #3553
Assignees
Labels
enhancement New feature or request

Comments

@nathaniel-may
Copy link
Contributor

Describe the feature

1 / n parses with the experimental parser should run both python jinja parsing and the experimental parser, compare results and send back whether they match or not. Frequency should be determined with an rng.

Describe alternatives you've considered

Not having this information

Additional context

We want to make sure the experimental parser is 100% in line with the existing python jinja rendering before we consider turning it on by default.

Who will this benefit?

dbt maintainers

Relevant Tickets

#3438

@jtcohen6
Copy link
Contributor

@nathaniel-may How do we want to account for known edge cases? For instance, we know that the experimental parser will not work right if the user has implemented custom versions of the ref, source, or config macros

@jtcohen6 jtcohen6 removed the triage label Jun 28, 2021
@nathaniel-may
Copy link
Contributor Author

for now those will fail. However, once those edge cases are accounted for they won't. And we'd want to see an RC with zero of these failures before moving to turn it on by default. So in my opinion it's ok to include this before we have all the edge cases covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants