add experimental parser tracking #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-may
force-pushed
the
cleaner-exp-parser-checks
branch
from
fc38f9e
to
22dca6e
Compare
4 tasks
jtcohen6
approved these changes
Jul 9, 2021
Comment on lines
+114
to
+123
| # fire a tracking event. this fires one event for every sample | ||
| # so that we have data on a per file basis. Not only can we expect | ||
| # no false positives or misses, we can expect the number model | ||
| # files parseable by the experimental parser to match our internal | ||
| # testing. | ||
| tracking.track_experimental_parser_sample({ | ||
| "project_id": self.root_project.hashed_name(), | ||
| "file_id": utils.get_hash(node), | ||
| "status": result | ||
| }) |
leahwicz
pushed a commit
that referenced
this pull request
Jul 9, 2021
leahwicz
added a commit
that referenced
this pull request
Jul 12, 2021
* return value from test function * add experimental parser tracking (#3553) Co-authored-by: Nathaniel May <[email protected]>
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
automatic commit by git-black, original commits: f460d27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3503
Description
Adds tracking for the experimental parser that samples correctness and includes what kind of mismatch may have occurred.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.