-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger full reparse if changes to widely used built-in macros #3810
Labels
Comments
Edit: any detected changes to these macros, or any macros that these macros depend on (via |
jtcohen6
changed the title
Trigger full reparse if changes to generate_x_name macro
Trigger full reparse if changes to widely used built-in macros
Sep 17, 2021
gshank
added a commit
that referenced
this issue
Sep 28, 2021
gshank
added a commit
that referenced
this issue
Sep 29, 2021
gshank
added a commit
that referenced
this issue
Sep 29, 2021
gshank
added a commit
that referenced
this issue
Sep 30, 2021
4 tasks
gshank
added a commit
that referenced
this issue
Sep 30, 2021
gshank
added a commit
that referenced
this issue
Oct 1, 2021
gshank
added a commit
that referenced
this issue
Oct 1, 2021
gshank
added a commit
that referenced
this issue
Oct 1, 2021
[#3810] Skip partial parsing if certain macros have changed
iknox-fa
pushed a commit
that referenced
this issue
Feb 8, 2022
automatic commit by git-black, original commits: 052a306
iknox-fa
pushed a commit
that referenced
this issue
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is a special category of macro that:
depends_on.macros
because of being so widely usedThose macros are:
ref
source
config
execute
(?)generate_schema_name
generate_database_name
generate_alias_name
The builtins are fairly self-explanatory (though
execute
is a weird inclusion in those docs).As for
generate_x_name
macros: The code that uses these macros is incredibly thorny, pretty old, and I think it has to do with a method namedgenerate_generate_component_name_macro
. I don't mind hard-coding that these seven need special treatment, and that any detected changes to them should be grounds for triggering a full re-parse (with logging + tracking to show for it).Opened as a bug because this currently yields incorrect results :)
The text was updated successfully, but these errors were encountered: