Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.10 compatibility (DeprecationWarning filling the logs) #4537

Closed
fvigo opened this issue Dec 29, 2021 · 2 comments
Closed

python 3.10 compatibility (DeprecationWarning filling the logs) #4537

fvigo opened this issue Dec 29, 2021 · 2 comments
Labels
bug Something isn't working tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@fvigo
Copy link

fvigo commented Dec 29, 2021

Hi,

when running some commands (i.e. dbt compile ) on python 3.10.0, I get tons of messages like these:

2021-12-29 09:45:49.495921 (MainThread): getName() is deprecated, get the name attribute instead
2021-12-29 09:45:49.496368 (MainThread): currentThread() is deprecated, use current_thread() instead

that clog the log file and the log buffer, resulting in errors also printed to stderr.

It looks like python 3.10 emits DeprecationWarning exceptions for these functions.

Tested on dbt 1.0.0:

 dbt --version
installed version: 1.0.0
   latest version: 1.0.0

Up to date!

Plugins:
  - bigquery: 1.0.0
@MartinNowak
Copy link

The deprecation warnings with Python 3.10 come from logbook which seems unmaintained.
https://github.com/getlogbook/logbook/blob/3e0badb395ed8d0038d02996d38aa0505441327e/logbook/concurrency.py#L47

MartinNowak added a commit to 7Learnings/dbt-core that referenced this issue Dec 31, 2021
- patch logbook for 3.10 compat
MartinNowak added a commit to 7Learnings/dbt-core that referenced this issue Jan 1, 2022
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality triage bug Something isn't working labels Jan 3, 2022
@emmyoop
Copy link
Member

emmyoop commented Jan 10, 2022

Thanks for the report @fvigo. We don't support Python 3.10 (yet!). Downgrading to Python 3.9 will resolve the deprecation errors you are experiencing for now.

I'm going to close this for now as we will resolve these with support for Python 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

4 participants