-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-1562] Remove PR# from changelogs #6332
[CT-1562] Remove PR# from changelogs #6332
Comments
@emmyoop Thanks for the thorough writeup, reflecting the conversation from Slack! I'm in favor of doing this.
👍 The other thing we discussed: A big change that's split into lots of little PRs (often against feature branches), all of which roll up into a single big coherent change. We should have a single big issue / epic, with links out to the PRs in its description, and a single changelog entry linking to that issue. Subsequent PRs can modify the changelog entry if they're expanding / modifying the scope of the overall change. Examples: |
Discussion:
|
We will want to backport this because it could otherwise cause changie to break the changelogs we backport. |
This is also relevant for |
The standard for changelogs in the industry is to link changes to either an issue or a PR, but generally not both. Currently we link to both for every changelog.
I propose we remove the PR from changelogs and only link to the issues related to the change. The only exception to this change would be dependabot and snyk changes because they never have issues. But for those we could remove the #4904 issue link completely and only link to the PR.
What's involved in this change:
dbt-docsThe text was updated successfully, but these errors were encountered: