Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1648] Remove PR# from changelogs #548

Closed
emmyoop opened this issue Dec 12, 2022 · 0 comments · Fixed by #603, #611 or #620
Closed

[CT-1648] Remove PR# from changelogs #548

emmyoop opened this issue Dec 12, 2022 · 0 comments · Fixed by #603, #611 or #620
Assignees

Comments

@emmyoop
Copy link
Member

emmyoop commented Dec 12, 2022

Part of dbt-labs/dbt-core#6332 - Removed PR from all changelog kinds except Dependencies and Security since those are bot generated by dependabot and snyk. Also adds support for multiple issues in a single changelog so features can have a single changelog with multiple issues.

  1. Update .changie.yaml to only use issue for all kinds (except Dependency & Security - use PRs only there). Also add support for multiple issues within a single changelog.
  2. Update change body in bot-changelog.yml to no longer include placeholder issue number. Also update kind in this file to be Dependencies instead of [Dependency] to match changie.yaml - this was an existing bug
  3. Existing changelog yaml files do not need to be modified to remove the extra fields. They will be ignored on generation. However the kind in the Dependency changelogs (if any exxist) do need to updated to have be kind: "Dependency"

Related dbt-core PR: dbt-labs/dbt-core#6374

These changes should be the same as the dbt-core PR with the exception of the Docs kinds as this repo does not have that kind.

@github-actions github-actions bot changed the title Remove PR# from changelogs [CT-1648] Remove PR# from changelogs Dec 12, 2022
@emmyoop emmyoop self-assigned this Jan 25, 2023
This was referenced Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants