Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agate type inference is too aggressive #861

Closed
drewbanin opened this issue Jul 18, 2018 · 2 comments
Closed

Agate type inference is too aggressive #861

drewbanin opened this issue Jul 18, 2018 · 2 comments
Assignees

Comments

@drewbanin
Copy link
Contributor

Via: http://agate.readthedocs.io/en/1.6.0/api/data_types.html

All:

Actual:
  null_values = ('', 'na', 'n/a', 'none', 'null', '.')
Desired:
  null_values = ('null')

Boolean:

Actual:
  true_values = ('yes', 'y', 'true', 't', '1')
  false_values = ('no', 'n', 'false', 'f', '0')
  null_values = ('', 'na', 'n/a', 'none', 'null', '.')
Desired:
  true_values = ('true')
  false_values = ('false')
  null_values = ('null')

TimeDelta

Actual:
  null_values = ('', 'na', 'n/a', 'none', 'null', '.')
Desired:
  null_values = ('null')

This would be a breaking change, so I think it's something we ought to do sooner rather than later.

@cmcarthur
Copy link
Member

document the heck out of it

@beckjake beckjake self-assigned this Aug 7, 2018
beckjake added a commit that referenced this issue Aug 9, 2018
…-inference

Agate less aggressive inference (#861)
@beckjake
Copy link
Contributor

beckjake commented Aug 9, 2018

fixed in #905

@beckjake beckjake closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants