Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google protobuf 5 is incompatible #9566

Closed
gshank opened this issue Feb 13, 2024 · 3 comments · Fixed by #9614 or #9630
Closed

Google protobuf 5 is incompatible #9566

gshank opened this issue Feb 13, 2024 · 3 comments · Fixed by #9614 or #9630

Comments

@gshank
Copy link
Contributor

gshank commented Feb 13, 2024

Description

We specify google.protobuf: "protobuf>=4.0.0". Google has come out with a release candidate for version 5 which is incompatible with our code because keyword parameters to MessageToJson and MessageToDict have been renamed. There may be other incompatibilities. We need to either change our upper limit to < 5.0.0 or support google.protobuf 5 in our code.

This was seen internally because a pipeline uses pip install --pre.

Acceptance Criteria

An incompatible version of google protobuf cannot be installed.

Will backports be required?

Yes. We need to limit the protobuf version in all versions of dbt Core that use google protobuf functions.

@graciegoheen graciegoheen added this to the v1.8 milestone Feb 13, 2024
@graciegoheen graciegoheen added Highest Severity critical bug that must be resolved immediately and removed Highest Severity critical bug that must be resolved immediately labels Feb 13, 2024
@peterallenwebb
Copy link
Contributor

dbt-common PR: dbt-labs/dbt-common#81

@graciegoheen
Copy link
Contributor

Reopening because #9614 only did the dev-requirements.txt

@josezeta
Copy link

Thanks, this fixed some production issues we got due the proto compatiility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants