Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming protobuf 5 contains breaking changes, restrict to 4 for now. #81

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Feb 21, 2024

Relates to #9566

Checklist

@peterallenwebb peterallenwebb requested a review from a team as a code owner February 21, 2024 15:42
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.04%. Comparing base (9a1f20a) to head (6ffef7b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   54.04%   54.04%           
=======================================
  Files          49       49           
  Lines        2866     2866           
=======================================
  Hits         1549     1549           
  Misses       1317     1317           
Flag Coverage Δ
unit 54.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank closed this Feb 22, 2024
@gshank gshank reopened this Feb 22, 2024
@gshank gshank added this pull request to the merge queue Feb 22, 2024
Merged via the queue into main with commit f532c4d Feb 22, 2024
24 checks passed
@gshank gshank deleted the paw/restrict-to-protobuf-4 branch February 22, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants