add --host flag to docs serve #10228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10228 +/- ##
==========================================
- Coverage 88.74% 88.73% -0.01%
==========================================
Files 180 180
Lines 22449 22451 +2
==========================================
Hits 19923 19923
- Misses 2526 2528 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2024
(cherry picked from commit c2d4643)
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2024
(cherry picked from commit c2d4643)
github-actions bot
pushed a commit
that referenced
this pull request
May 28, 2024
(cherry picked from commit c2d4643)
MichelleArk
pushed a commit
that referenced
this pull request
Jun 5, 2024
QMalcolm
added a commit
that referenced
this pull request
Jun 5, 2024
* add --host flag to docs serve (#10228) (cherry picked from commit c2d4643) * fix test_serve unit test --------- Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Quigley Malcolm <[email protected]>
QMalcolm
pushed a commit
that referenced
this pull request
Jun 5, 2024
* add --host flag to docs serve (#10228) (cherry picked from commit c2d4643) * fix test_serve unit test --------- Co-authored-by: Michelle Ark <[email protected]> Co-authored-by: Michelle Ark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10229
Problem
As part of GHSA-pmrx-695r-4349, we explicitly set 127.0.0.1 as the default bind address for dbt docs serve. However, we did not provide the ability for users to be able to override / opt-out of the default, and the change in default caused reported breakages in user deployments (example: #10208 (comment)).
Solution
dbt docs serve binds to '127.0.0.1' by default, but is possible to override via a new --host flag.
Checklist
🎩