add a check to make sure unit tests are considered when changing code #10337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenyuLInx
commented
Jun 18, 2024
There was a problem hiding this comment.
I think we should refactor https://github.com/dbt-labs/actions/blob/main/.github/workflows/changelog-existence.yml#L2 a bit to make it more generalized and use it here.
@emmyoop WDYT?
There was a problem hiding this comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10337 +/- ##
==========================================
+ Coverage 88.78% 88.81% +0.02%
==========================================
Files 180 180
Lines 22490 22486 -4
==========================================
+ Hits 19967 19970 +3
+ Misses 2523 2516 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ChenyuLInx
commented
Jun 18, 2024
| uses: actions/github-script@v7 | ||
| with: | ||
| script: core.setFailed('Unit Test required to merge.') | ||
| uses: dbt-labs/actions/.github/workflows/check-change-and-comment.yml@main |
There was a problem hiding this comment.
With the new action things should look much easier.
@emmyoop thoughts on this refactor and how to best test it?
MichelleArk
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10329
For new code checked in, we require 75% unittest coverage. We can always adjust if it becomes too noisy.
Docs about component https://about.codecov.io/blog/codecov-components-breaking-down-coverage-by-filters/