deprecations.buffer: respect --quiet and --warn-error-options for deprecations

[MichelleArk]

Resolves #10105

Problem

new deprecations in dbt config parsing does not respect --quiet or --warn-error-options

Solution

provide a way to buffer deprecations, and fire them once flags are initialized

Checklist

• I have read the contributing guide and understand what's expected of me.
• I have run this code in development, and it appears to resolve the stated issue.
• This PR includes tests, or tests are not required or relevant for this PR.
• This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
• This PR includes type annotations for new and modified functions.

🎩

❯ dbt parse
00:07:01  Running with dbt=1.9.0-a1
00:07:01  [WARNING]: Deprecated functionality

User config should be moved from the 'config' key in profiles.yml to the 'flags' key in dbt_project.yml.
00:07:01  target not specified in profile 'postgres', using 'default'
00:07:01  Registered adapter: postgres=1.9.0-a1
00:07:01  Performance info: /Users/michelleark/src/jaffle-shop/target/perf_info.json

❯ dbt --quiet parse

❯ dbt --warn-error-options "{'silence': ['ProjectFlagsMovedDeprecation']}" parse
00:07:39  Running with dbt=1.9.0-a1
00:07:39  target not specified in profile 'postgres', using 'default'
00:07:39  Registered adapter: postgres=1.9.0-a1
00:07:39  Performance info: /Users/michelleark/src/jaffle-shop/target/perf_info.json

❯ dbt --warn-error-options "{'include': ['ProjectFlagsMovedDeprecation']}" parse
00:07:52  Running with dbt=1.9.0-a1
00:07:52  Encountered an error:
Compilation Error
  [WARNING]: Deprecated functionality

  User config should be moved from the 'config' key in profiles.yml to the 'flags' key in dbt_project.yml.

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[MichelleArk]

I'd like to refactor the deprecated_env_var_warnings mechanism above to use the new deprecations.buffer pattern but will defer that to a follow-up PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (21a4633) to head (fdcb0b1).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10534      +/-   ##
==========================================
- Coverage   88.84%   88.82%   -0.02%     
==========================================
  Files         180      180              
  Lines       22717    22720       +3     
==========================================
- Hits        20182    20181       -1     
- Misses       2535     2539       +4     

Flag	Coverage Δ
integration	86.05% <100.00%> (-0.02%)	⬇️
unit	62.35% <92.30%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Unit Tests	62.35% <92.30%> (+0.03%)	⬆️
Integration Tests	86.05% <100.00%> (-0.02%)	⬇️

[gshank]

A nice neat solution!

[github-actions]

The backport to 1.8.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10534-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1dd26e79af721a5a3fc6ed8d464f9b4cb761ddad
# Push it to GitHub
git push --set-upstream origin backport-10534-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest

Then, create a pull request where the base branch is 1.8.latest and the compare/head branch is backport-10534-to-1.8.latest.